Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add new pull request template #73 #226

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Jun 2, 2020

Summary

Adding a new pull request template as per #73

How To Test

We will be able to test this once it is merged.

Question: Would you find the comments in the template helpful or annoying to work around?

Copy link
Contributor

@suzubara suzubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be good to add some comments that refer to the dangerJS checks (ie., did you run yarn audit, did you export any new components, etc.) as well as the conventional commits PR title requirement?

@haworku haworku merged commit f030ba6 into develop Jun 5, 2020
@haworku haworku deleted the hw-new-component-docs branch June 5, 2020 16:26
DanielMiller-agile6 pushed a commit to DanielMiller-agile6/react-uswds that referenced this pull request Jun 25, 2020
@haworku haworku mentioned this pull request Jun 29, 2020
haworku added a commit that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants